Use a TestResource for the Seasideserver #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure gems are shutdown after the tests
|
There is a breaking change: 'shouldEnsureSeasideServerStarted' is now on the class side instead of the instance side. It still controls if a Seaside server will be started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of 'ensuring to start' a seaside server for executing tests, I needed to be able to stop the server as well after running a testsuite. Converting the Seasideserver that is started for the tests to a testresource makes that possible.
This is required to fix broken tests in Gemstone after adding Parasol to execute the functional tests. The gemservers have separate testcases and having started gem servers from other testcases interferes with a correct run. Context: SeasideSt/Seaside#1199