Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GemStone: seasideMimeDocument should be implemented in CharacterCollection #1246

Closed
brunobuzzi opened this issue Mar 26, 2021 · 2 comments · Fixed by #1247
Closed

GemStone: seasideMimeDocument should be implemented in CharacterCollection #1246

brunobuzzi opened this issue Mar 26, 2021 · 2 comments · Fixed by #1247

Comments

@brunobuzzi
Copy link
Contributor

The current implementation of #seasideMimeDocument fail when GemStone return aUnicode16 (or other related string class) instead of aString.
brunobuzzi added a commit to brunobuzzi/Seaside-1 that referenced this issue Mar 26, 2021
@brunobuzzi
fix SeasideSt#1246
c37584c
@brunobuzzi brunobuzzi mentioned this issue Mar 26, 2021
Merged
@jbrichau
Copy link
Member

jbrichau commented Apr 3, 2021

@brunobuzzi do you have a scenario or testcase we can use? I'm wondering if a plaintext mime type is a good idea in case of a Unicode16 instance and also in what context you can end up with such an instance receiving the seasideMimeDocument message.

@brunobuzzi
Copy link
Contributor Author

@jbrichau i will try to create a TestCase and see in which situation anUnicode16 receives the message

jbrichau added a commit that referenced this issue Jan 23, 2022
@jbrichau
Merge pull request #1247 from brunobuzzi/master
ea7d47a 
fix #1246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix https://github.com/SeasideSt/Seaside/issues/1246 brunobuzzi/Seaside-1
2 participants
@jbrichau @brunobuzzi