Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1117 #1166

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Fix 1117 #1166

merged 1 commit into from
Dec 3, 2019

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Aug 27, 2019 •
edited
Loading

Fixes #1117:

  • adds class documentation
  • fixes crash when trying to list a directory when it's not allowed in the prefs.

@jbrichau
Fix bug in WAExternalFileLibrary crashing when trying to list a direc…
c01b6e3 
…tory when it's forbidden. Add documentation to the class.
@jbrichau jbrichau requested a review from jecisc August 27, 2019 15:12
@jbrichau jbrichau changed the base branch from master to develop August 27, 2019 15:12
@marschall marschall self-requested a review October 20, 2019 20:32
marschall
marschall approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@marschall marschall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrichau jbrichau merged commit 303f227 into develop Dec 3, 2019
@jbrichau jbrichau deleted the Fix-1117 branch December 3, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marschall marschall marschall approved these changes

@jecisc jecisc Awaiting requested review from jecisc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrichau @marschall