Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ETag support for file library #1325

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

marschall
Copy link
Contributor

Fixes #1324

@marschall
Copy link
Contributor Author

Requires SeasideSt/Grease#140

@marschall marschall added the CampSmalltalk 2022 Issues worked on at CampSmalltalk 2022 in Novi Sad label Aug 21, 2022
@jbrichau
Copy link
Member

The annoying situation here is that GemStone uses https://github.com/GsDevKit/Grease instead of the SeasideSt/Grease... which is why the tests are still failing (at least).
Will do the PR to GsDevKit to ping Dale.

@astares
Copy link
Contributor

astares commented Jun 30, 2023

Any update on this?

@jbrichau
Copy link
Member

jbrichau commented Jul 1, 2023

Any update on this?

I will take a look why the tests are failing for GemStone

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 89.58% and project coverage change: +0.01% 🎉

Comparison is base (c152487) 54.44% compared to head (95d0f2e) 54.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   54.44%   54.46%   +0.01%     
==========================================
  Files        8833     8837       +4     
  Lines       71719    71759      +40     
==========================================
+ Hits        39045    39080      +35     
- Misses      32674    32679       +5     
Files Changed Coverage Δ
...e.package/WAResponse.class/instance/notModified.st 0.00% <0.00%> (ø)
...bstractFileLibrary.class/instance/entityTagFor..st 100.00% <100.00%> (ø)
...re.package/WAFileLibrary.class/instance/handle..st 100.00% <100.00%> (ø)
...ge/WAFileMetadataLibrary.class/instance/handle..st 100.00% <100.00%> (ø)
...re.package/WARequest.class/instance/ifNoneMatch.st 100.00% <100.00%> (ø)
...re.package/WAResponse.class/instance/entityTag..st 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau merged commit 9d9ab4d into SeasideSt:master Sep 1, 2023
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CampSmalltalk 2022 Issues worked on at CampSmalltalk 2022 in Novi Sad
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ETag support for file library
3 participants