Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1355 ... solution is to ignore the sent but not implemented methods #1356

Merged
merged 2 commits into from
Mar 4, 2023
Merged

Issue 1355 ... solution is to ignore the sent but not implemented methods #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ae3c95
Issue #1355: for now just ignore #_continue and #array: in SentButNot…
dalehenrich Feb 23, 2023
b3831fb
Issue #1355: revert the BaselineOfSeaside3>>baselinegemstone: edit
dalehenrich Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions repository/BaselineOfSeaside3.package/.filetree
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"separateMethodMetaAndSource" : false,
"noMethodMetaData" : true,
"useCypressPropertiesFile" : true
}
"separateMethodMetaAndSource" : false,
"useCypressPropertiesFile" : true }
2 changes: 1 addition & 1 deletion ...itory/BaselineOfSeaside3.package/BaselineOfSeaside3.class/instance/baselinejavascript..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ baselinejavascript: spec
package: 'Javascript-Core'
with: [ spec includes: #('Javascript-GemStone-Core') ];
package: 'Javascript-GemStone-Core'
with: [ spec requires: #('Javascript-Core') ] ].
with: [ spec requires: #('Javascript-Core') ] ].
19 changes: 11 additions & 8 deletions repository/BaselineOfSeaside3.package/BaselineOfSeaside3.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
{
"commentStamp" : "",
"super" : "BaselineOf",
"category" : "BaselineOfSeaside3",
"classinstvars" : [ ],
"pools" : [ ],
"classvars" : [ ],
"instvars" : [ ],
"classinstvars" : [
],
"classvars" : [
],
"commentStamp" : "",
"instvars" : [
],
"name" : "BaselineOfSeaside3",
"type" : "normal"
}
"pools" : [
],
"super" : "BaselineOf",
"type" : "normal" }
2 changes: 1 addition & 1 deletion repository/BaselineOfSeaside3.package/monticello.meta/categories.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SystemOrganization addCategory: #BaselineOfSeaside3!
SystemOrganization addCategory: #'BaselineOfSeaside3'!
3 changes: 2 additions & 1 deletion repository/BaselineOfSeaside3.package/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
{ }
{
}
5 changes: 4 additions & 1 deletion ...ackage/SentButNotImplementedTest.extension/instance/nonImplementedSelectorsSeasideCore.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
*seaside-gemstone-core
nonImplementedSelectorsSeasideCore
^ #(#'javascript:' #'internalServerErrorMessage:') "WAScriptGenerator>>writeLoadScriptsOn: is the bad boy for javascript: and GRGemStonePlatform>>seasideProcessRequest:adaptor:resultBlock: is bad boy for internalServerErrorMessage:"
^ #(#'javascript:' #'internalServerErrorMessage:' #array: #'_continue') "WAScriptGenerator>>writeLoadScriptsOn: is the bad boy for javascript:
GRGemStonePlatform>>seasideProcessRequest:adaptor:resultBlock: is bad boy for internalServerErrorMessage:
JQJsonFunctionalTest>>seasidePackagesOn: is bad boy for array:
WARemoteDebuggingWalkback>>resumeContinuation is bad boy for _continue (https://github.com/SeasideSt/Seaside/issues/1355)"