Fix #initializeFromString: in WAUrl to take into account that ‘://’ can also be included in the query #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can also be included in the query (see: SeasideSt#1376).
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1377 +/- ##
==========================================
+ Coverage 54.17% 54.19% +0.02%
==========================================
Files 8887 8887
Lines 72215 72220 +5
==========================================
+ Hits 39121 39139 +18
+ Misses 33094 33081 -13
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #1376 by making
#initializeFromString:in WAUrl take into account that://can also be included in the query.The example this pull request adds to
#testNastyEdgeCasesParsingreflects the use of#absolute:in#requestUrlFor:in WAFastCGIRequestConverter: the argument to#absolute:is not a valid absolute URI as defined in section 4.3 in RFC 3986, as it does not begin with a scheme, but it is a valid request target as defined in section 3.2 in RFC 9112. WAUrl and WAFastCGIRequestConverter should maybe be made to better distinguish between those.