fix: Add PackageManifest stub class #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PackageManifest to prevent warnings when loading Pharo package manifest subclasses. Fixes SeasideSt#1382
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1384 +/- ##
=======================================
Coverage 48.67% 48.67%
=======================================
Files 8948 8948
Lines 80512 80512
=======================================
Hits 39192 39192
Misses 41320 41320 ☔ View full report in Codecov by Sentry. |
|
@theseion The package should also be added to the metacello baseline for Squeak |
|
It's already there, isn't it? baselinesqueak: spec
"Mind that baselinepharo still has a squeakcommon section!"
spec
for: #squeak
do: [
spec
package: 'Seaside-Squeak-Compatibility';
"..." |
|
@theseion Ow. I misread this as a new package but indeed. It already is there. |
jbrichau
approved these changes
Oct 31, 2023
theseion
deleted the
fix/1382-add-package-manifest-to-squeak-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PackageManifest to prevent warnings when loading Pharo package manifest subclasses.
Fixes #1382