-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use #greaseAsByteArray when computing etag #1385
Use #greaseAsByteArray when computing etag #1385
Conversation
This PR depends on SeasideSt/Grease#161. |
As soon as the mentioned PR is merged and we also get the GsDevKit/Grease mirror synced (necessary for GemStone builds), we can merge this one. |
Created the PR to also update Grease in GsDevkit/GLASS: GsDevKit/Grease#28 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1385 +/- ##
=======================================
Coverage 48.67% 48.67%
=======================================
Files 8948 8948
Lines 80512 80512
=======================================
Hits 39192 39192
Misses 41320 41320
☔ View full report in Codecov by Sentry. |
Pharo-12: a new deprecation that heavily impacts Monticello causes timeouts. |
Just to catch up a little, Squeak 6.1 now has #asByteArray for LargePositiveIntegers. Prior versions would simply need to use sometihng akin to
|
Thanks. I'm surprised you got it in after the discussions I saw on the mailing list 😉. |
On 2023-11-05, at 6:20 AM, Max Leske ***@***.***> wrote:
Thanks. I'm surprised you got it in after the discussions I saw on the mailing list 😉.
Oh, the privileges of being a 25+ year core developer and all that. It's a good point though that asByteArray is a pretty bad message, what with all the potential meanings. Should be using more specific names properly appropriate to the usage and in many case, not going that route at all. For example, applied to a bitmap in order to make the compression work... just daft.
tim
--
tim Rowledge; ***@***.***; http://www.rowledge.org/tim
Sarchasm (n): The gulf between the author of sarcastic wit and the person who doesn't get it.
|
Fixes #1383