Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use #greaseAsByteArray when computing etag #1385

Conversation

theseion
Copy link
Member

Fixes #1383

@theseion
Copy link
Member Author

This PR depends on SeasideSt/Grease#161.

@jbrichau
Copy link
Member

As soon as the mentioned PR is merged and we also get the GsDevKit/Grease mirror synced (necessary for GemStone builds), we can merge this one.

@jbrichau
Copy link
Member

jbrichau commented Nov 4, 2023

Created the PR to also update Grease in GsDevkit/GLASS: GsDevKit/Grease#28

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff85383) 48.67% compared to head (995a20b) 48.67%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1385   +/-   ##
=======================================
  Coverage   48.67%   48.67%           
=======================================
  Files        8948     8948           
  Lines       80512    80512           
=======================================
  Hits        39192    39192           
  Misses      41320    41320           
Files Coverage Δ
...bstractFileLibrary.class/instance/entityTagFor..st 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theseion
Copy link
Member Author

theseion commented Nov 4, 2023

Pharo-12: a new deprecation that heavily impacts Monticello causes timeouts.
Others: unrelated test failures.

@timrowledge
Copy link

Just to catch up a little, Squeak 6.1 now has #asByteArray for LargePositiveIntegers. Prior versions would simply need to use sometihng akin to

^theBigNumber as: ByteArray

@theseion
Copy link
Member Author

theseion commented Nov 5, 2023

Thanks. I'm surprised you got it in after the discussions I saw on the mailing list 😉.

@timrowledge
Copy link

timrowledge commented Nov 6, 2023 via email

@jbrichau jbrichau merged commit 7976eb9 into SeasideSt:master Nov 11, 2023
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Squeak does not have an implementation of Integer>>#asByteArray
3 participants