baseline changes needed to properly load Seaside into a 3.6.7 extent0.seaside.dbf ... #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…follow the Monticello package naming conventions
… older versions of Metacello to properly load Seaside
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1388 +/- ##
==========================================
- Coverage 48.67% 48.64% -0.04%
==========================================
Files 8948 8954 +6
Lines 80512 80572 +60
==========================================
Hits 39192 39192
- Misses 41320 41380 +60
☔ View full report in Codecov by Sentry. |
dalehenrich
changed the title
jbrichau
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older version of Metacello being used in extent0.seaside.dbf was not properly dealing with the fact that the required packages for the newish HotwireTurbo packages were not complete and resulted in undefined globals. Adjusting the required packages for the HotwireTurbo packages fixed the package load order issue and reqolved the undefined global references.
Another point is that the Seaside-HotwireTurbo and Seaside-HotwireTurbo-Examples share a common base name for the package which is in violation of the Monticello package naming conventionsand would lead to unwanted package mangling if the HotwireTurbo were modified and saved from an image that follows the Monticello package naming convention. So I renamed Seaside-HotwireTurbo to Seaside-HotwireTurbo-Core to avoid this potential issue.