Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CORS test on github actions #1400

Merged
merged 57 commits into from
Jan 28, 2024
Merged

Fix CORS test on github actions #1400

merged 57 commits into from
Jan 28, 2024

Conversation

jbrichau
Copy link
Member

After searching for over a day to debug and understand... it turns out changing the port from 8084 to 8888 was what was needed to make this work on Github CI....

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e440868) 48.35% compared to head (24d01c4) 48.42%.

❗ Current head 24d01c4 differs from pull request most recent head 5cd2159. Consider uploading reports for the commit 5cd2159 to get more accurate results

Files Patch % Lines
...rFunctionalTestCase.class/instance/clickRestart.st 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1400      +/-   ##
==========================================
+ Coverage   48.35%   48.42%   +0.06%     
==========================================
  Files        9159     9161       +2     
  Lines       82123    82141      +18     
==========================================
+ Hits        39711    39774      +63     
+ Misses      42412    42367      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau merged commit 61d83eb into master Jan 28, 2024
11 of 24 checks passed
@jbrichau jbrichau deleted the testfixing branch January 28, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant