Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Glamorous Toolkit #1437

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Add Glamorous Toolkit #1437

merged 2 commits into from
Jul 17, 2024

Conversation

Rinzwind
Copy link
Member

This pull request adds ‘GToolkit64-release’ to the list for ‘smalltalk’ in ‘ci.yml’.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.04%. Comparing base (cb4b8ef) to head (c0e63ad).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1437   +/-   ##
=======================================
  Coverage   49.04%   49.04%           
=======================================
  Files        9143     9143           
  Lines       80555    80555           
=======================================
  Hits        39506    39506           
  Misses      41049    41049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ionary, OrderedDictionary and SequenceableCollection when testing on Glamorous Toolkit (see issue #1433, “Implementations of #asJson in Seaside and GToolkit conflict”).
@Rinzwind Rinzwind requested a review from jbrichau July 16, 2024 17:18
@Rinzwind
Copy link
Member Author

Screenshot of the Seaside Welcome page in Glamorous Toolkit using the GtWebView that was recently added (see GToolkit issue #3849):

@jbrichau jbrichau merged commit f681d92 into master Jul 17, 2024
22 of 26 checks passed
@jbrichau jbrichau deleted the gtoolkit branch July 17, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants