implemented Import csv from filemanger #52
Conversation
* incremented java to version 11 to allow java stream api * added interface NameWithIdProvider to entities to allow generic translation between id and name * created empty CsvExporter with a failing junit4-test
SecUSo#42: export to csv first version
SecUSo#42: implemented createCsvHeader; extracted CSV_FIELD_DELIMITER
…ose; added a Writer argument to CsvExporter constructor; extracted ICSVWriter variable
SecUSo#42: merged openCsv implementation
…CSV functionality
…CSV functionality
SecUSo#42: created fileUtils
SecUSo#42: re-added accidently deleted unittest
SecUSo#42: fixes from codereview
…ons, CsvImporterTest classes
SecUSo#51: created branch ImportCsv. Created CsvImporter, CsvDefinitions, C…
SecUSo#51: created failing unittest
…mment starts with '#'; Duplicated transactions (same data as exising) are ignored
test: readCsvNoteCaseInsensitive test created to check if it works
There was a problem hiding this comment.
As far as I can see, I can only do the import if I open the CSV file from another app. I think many users will not discover the feature this way. Would it be possible to add an Import button to the Transactions menu, like the Export button?
Apart from a few minor issues, it looks good to me. 👍
| <string name="nav_title_export_as_csv">Als CSV exportieren</string> | ||
|
|
||
| <!-- parameter 1: specific text parameter 2 exception messasage --> | ||
| <string name="err_cannot_read_import_file">Kann CSVDatei nicht lesen aus %s : %s</string> |
There was a problem hiding this comment.
Should be Kann CSV-Datei nicht lesen aus %s : %s
| <!-- parameter 1: specific text parameter 2 exception messasage --> | ||
| <string name="err_cannot_read_import_file">Kann CSVDatei nicht lesen aus %s : %s</string> | ||
| <string name="err_cannot_save_to_db">Kann %s nicht in Datenbank speichern\n\t %s</string> | ||
| <string name="info_import_success">Ergebnis: (%s/%s) Transactionen importiert</string> |
There was a problem hiding this comment.
Typo: Ergebnis: (%s/%s) Transaktionen importiert
| } catch (Exception ex) { | ||
| addError(ex.getMessage()); | ||
| } | ||
| System.out.println(line); |
There was a problem hiding this comment.
Please remove this debug output.
|
I (k3b) currently have no contact to my former student (MaxIsV) I try to fix this |
|
I have no write permission for MaxIsV:ImportCsv. I will try tomorrow ..... |
|
I created a new pullrequest #56 with the fixes that will replace this request. @udenr :
I totally agree. I have added a new issue #57 because handling this would require additional read-from-file-permissions |
|
@udenr is it ok to merge import without the proposed menu item? |
|
I will close this because it was replaced by #56 |
No description provided.