-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual improvement #86
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # app/src/main/java/org/secuso/privacyfriendlyfoodtracker/ui/OverviewActivity.java # app/src/main/java/org/secuso/privacyfriendlyfoodtracker/ui/WeekStatisticFragment.java
Hi! I will add new pull request to finish Weight functionality when it will be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a major update with the Backup Integration which caused some merge conflicts. Can you have a look?
date = date + (86400000 * i); | ||
refreshData(); | ||
viewModel.getList().observe(this, new Observer<List<DatabaseEntry>>() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this observed over and over again? This should only be done once the activity loads. The ViewModel should be responsible to always supply the correct information.
Visual changes:
Logical changes:
Planed changes:
if everything is fine I can rebase