Store salt value inside the app instead of using deviceID #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add second preference file to backup - replace string literals with constants - update how seed value is retrieved
- Fix hard coded default value in MainActivity.java
udenr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the android deviceID when "bindToDevice" is enabled, this will now use an "installation salt". If this version is installed as an update the deviceID will be stored as the "installation salt". If it's a new installation a random salt will be generated. The salt is then included in backups created with the Privacy Friendly Backup app.
Closes Add a salt to password generation instead of device id #40