This repository has been archived by the owner on Apr 19, 2021. It is now read-only.
Remove redundant source call #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the top of the script, a call to source /etc/nsm/securityonion.conf however, later in the script when there's a check if ELSA is defined another call to source /etc/nsm/securityonion.conf is done (along with check to see if the file exists first). I simply moved the file check code up to the top of the script and simplified the if statement that looks to see if ELSA is defined.
At the top of the script is a call to 'source /etc/nsm/securityonion.conf' however, later in the script when there's a check if ELSA is defined, another call to source /etc/nsm/securityonion.conf is done (along with check to see if the file exists first). I simply moved the file check code up to the top of the script and simplified the if statement that checks if ELSA is defined.
…onion-sostat into pull-request-nullglob Amend the commit message
|
Thanks @zestysoft ! |
dougburks
added a commit
that referenced
this pull request
Sep 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the top of the script is a call to
'source /etc/nsm/securityonion.conf' however, later in the script
when there's a check if ELSA is defined, another call to source
/etc/nsm/securityonion.conf is done (along with check to see if the
file exists first). I simply moved the file check code up to the top
of the script, removed the redundant source call, and simplified the
if statement that checks if ELSA is defined.