Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added BottomSheetTheme parser and provided in MiraiTheme #137

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

i-asimkhan
Copy link
Contributor

Description

Added BottomSheet theme parser and provided in Mirai Theme

Related Issues

Closes #128

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@i-asimkhan i-asimkhan self-assigned this May 24, 2023
* main:
  Added `MiraiBottomAppBarTheme` in `MiraiThemeData`
  Secondary color for light and dark themes are changed for mirai_gallery
  Secondary color changed and default values are removed in light/dark theme
  Renamed `MiraiFloatingActionThemeData` to `MiraiFloatingActionButtonThemeData` and removed example theme comp from light theme
  Added `iconColor` and `disabledIconColor` in mirai button style
  Removed TextButtonThemeData wrapper on button
  Removed app-bar theme from light-theme example and icon theme irrelevant values causing color disruption
  Fixed file naming misspelled word for `overlay` in mirai sustem ui overly
  Added iconTheme and actionIconTheme values in MIrai app-bar theme data
  Fix code formatting
  Updated example theme for bottom-nav-bar and formatted parsers in the framework
  Added bottom-nav-bar theme data in Mirai theme
  Updated floating action button example jsons.
  Added floating action button theme parser in mirai/parsers
  Modified example json for text theme data values
  Added mirai text button theme data parser in mirai/parsers
  Updated `appBarTheme` values for icon theme in parser and example
  Added basic structure for appbar theme in `MiraiTheme`

# Conflicts:
#	examples/mirai_gallery/assets/json/example_light_theme.json
#	packages/mirai/lib/src/parsers/mirai_theme/mirai_theme.dart
#	packages/mirai/lib/src/parsers/mirai_theme/mirai_theme.freezed.dart
#	packages/mirai/lib/src/parsers/mirai_theme/mirai_theme.g.dart
@divyanshub024 divyanshub024 added this to the v0.3.0 milestone Jun 5, 2023
@i-asimkhan i-asimkhan changed the title feat: Added BottomSheet theme parser and provided in Mirai Theme feat: Added BottomSheetTheme parser and provided in MiraiTheme Jun 5, 2023
@divyanshub024 divyanshub024 merged commit 6627555 into main Jun 6, 2023
@divyanshub024 divyanshub024 deleted the asim/bottom-sheet-theme branch June 6, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add support for bottomSheetTheme in MiraiTheme
2 participants