Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Mirai WebView package #197

Merged
merged 4 commits into from
Sep 7, 2023
Merged

feat: Add Mirai WebView package #197

merged 4 commits into from
Sep 7, 2023

Conversation

divyanshub024
Copy link
Contributor

Description

This PR adds a package to provide support for the WebView.

Related Issues

closes #190

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@divyanshub024 divyanshub024 marked this pull request as ready for review September 6, 2023 16:34
i-asimkhan
i-asimkhan approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@i-asimkhan i-asimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If we merge this, would it still merge without PR check's success?

@divyanshub024 divyanshub024 merged commit abbe6d1 into main Sep 7, 2023
0 of 3 checks passed
@divyanshub024 divyanshub024 deleted the dv/mirai_webview branch September 7, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-asimkhan i-asimkhan i-asimkhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add support for webview
2 participants
@divyanshub024 @i-asimkhan