feat: Add support for Filled Button #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a Mirai Filled Button Parser ✅ - Added example to the Mirai gallery ✅
home screen updated
home screen updated alignment
divyanshub024
changed the title
divyanshub024
suggested changes
Feb 28, 2024
There was a problem hiding this comment.
Hey @iampranabray 👋🏻
Once again, Thank you for such amazing contributions.
I have some suggestions, please check my comments.
packages/mirai/lib/src/parsers/mirai_filled_button/mirai_filled_button_parser.dart
Outdated
Show resolved
Hide resolved
packages/mirai/lib/src/parsers/mirai_filled_button/mirai_filled_button_parser.dart
Outdated
Show resolved
Hide resolved
added comments are addressed++ - focusnode and materialStatesController removed - parseFilledButton added by removing parseElevated
freezed button file updated
|
@iampranabray Can you please resolve these conflicts? |
Yha sure |
Signed-off-by: Divyanshu Bhargava <divyanshub024@gmail.com>
divyanshub024
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Closes #264
Type of Change