Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genbil - column index propagated into the transformation element #392

Closed
fefeslon opened this issue Jul 13, 2018 · 5 comments
Closed

Genbil - column index propagated into the transformation element #392

fefeslon opened this issue Jul 13, 2018 · 5 comments

Comments

@fefeslon
Copy link

Hi All,

When I generate the test suite using the .nbitx template with transformation element used the generation process adds column index element into it as well (see below):

nbitx template:

<assert>
    <equalTo>
      <column index="0" role="key" type="numeric" />
      <column index="1" role="value" type="numeric">
        <transformation language="native" >
          null-to-value
        </transformation>
      </column>

generated nbits file (with column-index="0" added into the transformation element):

<assert>
      <equalTo>
        <column index="0" role="key" type="numeric" />
        <column index="1" role="value" type="numeric">
          <transformation column-index="0" language="native">
          null-to-value
        </transformation>
        </column>

Could you fix it please?

Cheers.

@Seddryck
Copy link
Owner

I published an alpha version a few hours ago at https://ci.appveyor.com/project/Seddryck/nbi/build/artifacts

If you confirm it's OK, I'll merge to the develop line, create a beta, integrate it in next RC and release.

@Seddryck Seddryck added this to the v1.19 milestone Jul 21, 2018
@fefeslon
Copy link
Author

fefeslon commented Jul 23, 2018

Hey Cedric,

The column index = 0 error has been fixed, however the new block of code has appeared (InternalTransformationInner tag) in the generated nbits file.

Error message in nunit:
The element 'column' in namespace 'http://NBi/TestSuite' has invalid child element 'InternalTransformationInner' in namespace 'http://NBi/TestSuite'.

Nbitt template (I have tried both the transform and the transformation tags):

    <equalTo>
      <column index="0" role="key" type="numeric"/>
      <column index="1" role="value" type="numeric">
        <transform language="native" >
          null-to-value
        </transform>
      </column>
      <column index="2" role="value" type="numeric">
        <transformation language="native" >
          null-to-value
        </transformation>        
      </column>

Nbits result:

      <equalTo>
        <column index="0" role="key" type="numeric" />
        <column index="1" role="value" type="numeric">
          <transform language="native">
          null-to-value
        </transform>
          <InternalTransformationInner language="native">
          null-to-value
        </InternalTransformationInner>
        </column>
        <column index="2" role="value" type="numeric">
          <transform language="native">
          null-to-value
        </transform>
          <InternalTransformationInner language="native">
          null-to-value
        </InternalTransformationInner>
        </column>

@Seddryck
Copy link
Owner

@fefeslon
Copy link
Author

fefeslon commented Jul 23, 2018

Yep, now it looks ok!

Thanks for the fix.

Seddryck pushed a commit that referenced this issue Jul 23, 2018
@Seddryck
Copy link
Owner

Seddryck commented Jul 23, 2018

Thx for the feedback! Merged to the development branch and beta released at https://ci.appveyor.com/project/Seddryck/nbi/build/1.19.0-beta.42.build.433/artifacts or Update-Package NBi.Framework -Version 1.19.0-beta0042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants