Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result-set file ignored using genbil (not generated) #514

Closed
fefeslon opened this issue Sep 6, 2019 · 3 comments
Closed

Result-set file ignored using genbil (not generated) #514

fefeslon opened this issue Sep 6, 2019 · 3 comments

Comments

@fefeslon
Copy link

fefeslon commented Sep 6, 2019

Hi All,

I am trying to generate the test where the result set is a csv file.

I am using the version 1.20.

After generating the tests using the genbil, result-set tag is visible, but the file is missing in the code.

See below:

Template:

<system-under-test>
    <result-set file="..\csv\test.csv"/>
</system-under-test>

generated code (nbits):

Template:

<system-under-test>
    <result-set />
</system-under-test>

Note: When I copy the file="..\csv\test.csv" into the generated nbits file, the test is working.

Also the assert part works only if I write it using the "old" syntax:

<assert>
   <equal-to>
      <resultSet file="..\test.csv"/>
   </equal-to>

instead of the:

<assert>
   <equal-to>
      <result-set file="..\test.csv"/>
   </equal-to>

Could you check it please and let me know if I am missing something or it is a bug?

Cheers.

@Seddryck Seddryck changed the title result-set file ignored using genbil (not generated) Result-set file ignored using genbil (not generated) Sep 7, 2019
@Seddryck
Copy link
Owner

Seddryck commented Sep 7, 2019

Version 1.20 introduced a new syntax for the file attribute. The following syntax is considered non-canonical (but is still valid as a shortcut):

<system-under-test>
    <result-set file="..\csv\test.csv"/>
</system-under-test>

and should be replaced by (#444 and #442 offer new opportunities requiring to have an element and not anymore an attribute).

<system-under-test>
    <result-set>
        <file>
            <path>..\csv\test.csv</path>
        </file>
    </result-set>
</system-under-test>

Anyway, the non-canonical syntax should still be supported by genbiL (in a template) ... but the output will be the canonical version.

Seddryck pushed a commit that referenced this issue Sep 7, 2019
@Seddryck
Copy link
Owner

Seddryck commented Sep 7, 2019

About the issue with genbiL, take a look at my comment above but I just checked your issue on 1.21-beta and I cannot reproduce. With this template, I have the following result.

I didn't check with v1.20 but I'd recommend to update genbi.exe (and dlls) to v1.21 to fix this potential issue.

About the issue with result-set in the assert part of the test, #354 is part of 1.21, not really surprised that it doesn't fully work in 1.20 ;-)

@Seddryck Seddryck closed this as completed Sep 7, 2019
@Seddryck Seddryck modified the milestone: v1.21 Sep 7, 2019
@fefeslon
Copy link
Author

fefeslon commented Sep 9, 2019

Ok,

It is working the 1.21 beta.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants