Add Impala-to-Lua Transpiler, Add Lua Math Functions, Re-Enable Unit Tests #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davschneller
force-pushed
the
davschneller/transpile-impala
branch
from
ad2e756
to
44562bf
Compare
davschneller
changed the title
davschneller
force-pushed
the
davschneller/transpile-impala
branch
from
44562bf
to
39188c2
Compare
vikaskurapati
approved these changes
Sep 27, 2024
external/CMakeLists.txt
Outdated
| message("Enabled Lua lmathx support.") | ||
|
|
||
| if (LUA_VERSION_STRING VERSION_GREATER_EQUAL "5.5") | ||
| message(WARNING "You Lua version ${LUA_VERSION_STRING} is newer than the maximum lmathx package version supported (5.4.x). We'll try with the version compatible to 5.4/5.3, but no guarantee on success for that.") |
There was a problem hiding this comment.
Typo: "Your"?. But what do we suggest the user if their LUA version is greater than 5.5? Just downgrade to 5.4.x?
There was a problem hiding this comment.
Yes, typos. :)
We can suggest a downgrade here.
external/CMakeLists.txt
Outdated
| elseif (LUA_VERSION_STRING VERSION_GREATER_EQUAL "5.1") | ||
| target_sources(easi PRIVATE lua51/lmathx.c) | ||
| else() | ||
| message(FATAL_ERROR "You Lua version ${LUA_VERSION_STRING} is older than the minimum lmathx package version supported (5.1).") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a small and quickly-written tokenizer and parser for Impala (akin to what's done over there in the repository, but with a bit more manual labor). Probably it's actually overkill to walk down the Impala ast here, since the Impala/C and Lua syntax are pretty similar in their behavior. Right now, every Impala function gets converted to one Lua function (it may also be easily possible to merge all functions into one (you'd "just" need to track the returns for that and shift code into
elseblocks, if there's areturnin anif); but I'm not sure if that's really useful).As a result, ImpalaJIT is no longer required to run a
FunctionMap; only Lua is.Also, we refactor the Lua function evaluation a tiny bit, and cut down the number of calls by the number of output parameters (so far, a function was executed for each output value again, even though the execution should result in exactly the same result). Would be interesting to think about supporting LuaJIT.
Furthermore, we now by default include the
lmathxLua library; thus the whole C math header should be effectively available now (the code for that is under public domain—I've just put it into the repo for now).Also, the unit tests get re-enabled and fixed.