Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci mypy errros #1012

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix ci mypy errros #1012

merged 1 commit into from
May 21, 2024

Conversation

mauicv
Copy link
Collaborator

@mauicv mauicv commented May 20, 2024

What is this

This PR fixes mypy errors that are arising in CI`

Note: Doc builds and licenses are failing. To be fixed in a different PR

@mauicv mauicv self-assigned this May 20, 2024
@CLAassistant
Copy link

CLAassistant commented May 20, 2024

CLA assistant check
All committers have signed the CLA.

@mauicv mauicv requested a review from RobertSamoilescu May 20, 2024 15:37
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.16%. Comparing base (8a1eb1c) to head (681113b).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
- Coverage   85.23%   85.16%   -0.08%     
==========================================
  Files          74       74              
  Lines        8834     8796      -38     
==========================================
- Hits         7530     7491      -39     
- Misses       1304     1305       +1     
Files Coverage Δ
alibi/datasets/default.py 93.52% <100.00%> (+0.04%) ⬆️
alibi/explainers/pd_variance.py 98.37% <ø> (ø)
alibi/utils/visualization.py 47.79% <0.00%> (-0.31%) ⬇️

... and 7 files with indirect coverage changes

@mauicv mauicv merged commit 4cca971 into SeldonIO:master May 21, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants