-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EFK with transform for tabular data #616
EFK with transform for tabular data #616
Conversation
…me changed vs katacoda
For images we may be better to store the image on disk or in a bucket and keep a searchable reference to it. I'd like to investigate computing metadata about the image before storing it so that you could search by metadata (e.g. presence of certain colours) - see https://stackoverflow.com/questions/30440224/possible-to-store-images-in-elasticsearch We should discuss whether to do this in the engine or in a wrapper library or even start with just an example of how it can be done in the end-user code |
Next steps:
|
New idea - look at performing the enrichment in a separate batch job that updates the entries in elasticsearch or an elasticsearch transform script - preferably we'd do something python-based to simplify working with the arrays. In that case the transformation/enrichment part in the engine for this PR would be taken out. |
Related to SeldonIO/seldon-operator#13 but not a dependency |
Depends on SeldonIO/seldon-operator#17 |
* add UnloadEnvoyRequested state * transition to UnloadEnvoyRequested * add UnloadEnvoyRequested in model stats * add UnloadEnvoyRequested in UnloadingOrUnloaded * make removeRouteForServerInEnvoy not sync * update func name to reflect how envoy is called * modelUpdate changes to proceed with batched rm * add TODO for pipeline envoy updates * remove unused field in ModelVersion * move field to atomic.bool * fix condition check * add tests * fix unload test * lint * fix lint issues * add extra test * docs update * add new replicastate in protos * update generated protos * add extra test in agent-server sync
Alternative to #610
In this version the engine can do a transform to put tabular data into key-value pairs for searching. We can then do e.g. value-range searches:
It checks whether there's a 'data.names' array before transforming but need to do more checks to make sure this won't break other types of requests (e.g. what can we assume about the data value type and array shape). Also need to consider performance.