[rb] update guards for tests on Windows

SeleniumHQ · Nov 2, 2022 · 718f4f2 · 718f4f2
1 parent 878ce7e
commit 718f4f2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
@@ -317,7 +317,7 @@ module WebDriver
 
       describe '#scroll_by', only: {browser: %i[chrome edge firefox]} do
         it 'scrolls by given amount', except: {browser: :firefox,
-                                               platform: :macosx,
+                                               platform: %i[macosx, windows],
                                                reason: 'scrolls insufficient number of pixels'} do
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
           footer = driver.find_element(tag_name: 'footer')

diff --git a/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb b/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb
@@ -110,7 +110,8 @@ module Firefox
             expect(driver.find_elements(id: 'webextensions-selenium-example')).to be_empty
           end
 
-          it 'install and uninstall signed directory' do
+          it 'install and uninstall signed directory', except: {platform: :windows,
+                                                                reason: 'signature must be different for windows'} do
             ext = File.expand_path("#{extensions}/webextensions-selenium-example-signed/", __dir__)
             id = driver.install_addon(ext)
 

diff --git a/rb/spec/integration/selenium/webdriver/zipper_spec.rb b/rb/spec/integration/selenium/webdriver/zipper_spec.rb
@@ -57,8 +57,7 @@ def create_file
           expect(File).to exist(zip_file)
         end
 
-        # Bug - `File.symlink` has permissions issues on Windows
-        it 'follows symlinks', except: {platform: :windows} do
+        it 'follows symlinks' do
           filename = create_file
           File.symlink(filename, File.join(dir_to_zip, 'link'))