Skip to content

Commit

Permalink
[rb] update guards for flaky tests
Browse files Browse the repository at this point in the history
  • Loading branch information
titusfortner committed Oct 31, 2023
1 parent 4434e02 commit 9de989a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion rb/spec/integration/selenium/webdriver/remote/driver_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ module Remote
expect(driver.status).to be_a(Hash)
end

it 'uses a default file detector' do
it 'uses a default file detector',
flaky: {browser: :safari, ci: :github, reason: 'unreliable with downloads'} do
driver.navigate.to url_for('upload.html')

driver.find_element(id: 'upload').send_keys(__FILE__)
Expand Down
6 changes: 4 additions & 2 deletions rb/spec/integration/selenium/webdriver/remote/element_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ module WebDriver
end

context 'when uploading one file' do
it 'uses the provided file detector', exclusive: {driver: :remote}, flaky: {browser: :safari, ci: :github} do
it 'uses the provided file detector', exclusive: {driver: :remote},
flaky: {browser: :safari, ci: :github, reason: 'unreliable with downloads'} do
driver.navigate.to url_for('upload.html')

driver.find_element(id: 'upload').send_keys('element_spec.rb')
Expand All @@ -47,7 +48,8 @@ module WebDriver
end

context 'when uploading multiple files' do
it 'uses the provided file detector', exclusive: {driver: :remote}, flaky: {browser: :safari, ci: :github} do
it 'uses the provided file detector', exclusive: {driver: :remote},
flaky: {browser: :safari, ci: :github, reason: 'unreliable with downloads'} do
driver.navigate.to url_for('upload_multiple.html')

driver.find_element(id: 'upload').send_keys("driver_spec.rb\nelement_spec.rb")
Expand Down

0 comments on commit 9de989a

Please sign in to comment.