[🐛 Bug]: ensure python uses SE_MANAGER_PATH as a pathlib.Path

[bollwyvl]

What happened?

When SE_MANAGER_PATH is set, the python implementation uses it directly as a str rather than a Path, but then tries to use Path.is_file.

How can we reproduce the issue?

import os
os.environ["SE_MANAGER_PATH"] = "some/actual/path/to/an/existing/selenium-manager"
from selenium.webdriver.common.selenium_manager import SeleniumManager
assert SeleniumManager.get_binary().exists()

Relevant log output

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File ".../lib/python3.12/site-packages/selenium/webdriver/common/selenium_manager.py", line 60, in get_binary
    if not path.is_file() and os.environ["CONDA_PREFIX"]:
           ^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'is_file'

Operating System

CentOS7

Selenium version

4.14.0

What are the browser(s) and version(s) where you see this issue?

What are the browser driver(s) and version(s) where you see this issue?

Are you using Selenium Grid?

[github-actions]

@bollwyvl, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[symonk]

Thanks!

[bollwyvl]

I think the patch in e15fed5 was missing some parens: sorry I didn't catch it initially, I don't have a lot of walrus experience. We shipped this on conda-forge/selenium-feedstock#69

--- a/selenium/webdriver/common/selenium_manager.py
+++ b/selenium/webdriver/common/selenium_manager.py
@@ -41,7 +41,7 @@ class SeleniumManager:
         :Returns: The Selenium Manager executable location
         """
 
-        if path := os.getenv("SE_MANAGER_PATH") is not None:
+        if (path := os.getenv("SE_MANAGER_PATH")) is not None:
             return Path(path)
         else:
             platform = sys.platform

[titusfortner]

@symonk / @isaulv / @AutomatedTester can someone verify the logic above? I can get a patch release out if what we have isn't correct.

[isaulv]

@titusfortner verified that you need parentheses. Without it, path becomes True.

[titusfortner]

fixed, releasing 4.15.1

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.