Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: There are still some leftovers from the HtmlUnit removal #13171

Closed
rbri opened this issue Nov 19, 2023 · 10 comments
Closed

[🐛 Bug]: There are still some leftovers from the HtmlUnit removal #13171

rbri opened this issue Nov 19, 2023 · 10 comments
Labels
help wanted Issues looking for contributions I-defect

Comments

@rbri
Copy link
Contributor

rbri commented Nov 19, 2023

What happened?

Looks like there are some leftovers from [java] remove the unused htmlunit-driver from the unit tests (#12849).

  • "net.sourceforge.htmlunit:htmlunit-core-js:2.70.0" is still referenced from some bzl scripts as dependency
  • java\test\org\openqa\selenium\atoms\CompiledAtomsNotLeakingTest.java is base on core-js but the referenced RESOURCE_PATH = "/org/openqa/selenium/atoms/execute_script.js" no longer exists
  • java\test\org\openqa\selenium\atoms\InputAtomsTest.java is base on core-js but the referenced RESOURCE_PATH = "/org/openqa/selenium/atoms/atoms_inputs.js" no longer exists

How can we reproduce the issue?

* verify if the tests (CompiledAtomsNotLeakingTest.java, InputAtomsTest.java) are still part of the test suite and passing

Relevant log output

nothing

Operating System

any

Selenium version

any

What are the browser(s) and version(s) where you see this issue?

any

What are the browser driver(s) and version(s) where you see this issue?

any

Are you using Selenium Grid?

no

Copy link

@rbri, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@pujagani
Copy link
Contributor

Thank you for reporting and providing the issue. Would you like to send a PR and help contribute? :)

@pujagani pujagani added the help wanted Issues looking for contributions label Nov 20, 2023
Copy link

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

@rbri
Copy link
Contributor Author

rbri commented Nov 20, 2023

Sorry i really have no time to work on that - maybe @joerg1985 who did the original pr for removing has an idea why we still have this dependency.

@joerg1985
Copy link
Member

I will take care of this, as soon as i find the time.

mmccartn pushed a commit to mmccartn/selenium that referenced this issue Dec 7, 2023
Updates the HtmlUnit Java dependency to the latest major release
according to the migration guide:
https://www.htmlunit.org/migration.html

Resolves: vulnerability CVE-2023-26119

Related SeleniumHQ#13171
mmccartn added a commit to mmccartn/selenium that referenced this issue Dec 8, 2023
Updates the HtmlUnit Java dependency to the latest major release
according to the migration guide:
https://www.htmlunit.org/migration.html

Resolves: vulnerability CVE-2023-26119

Related SeleniumHQ#13171
diemol added a commit that referenced this issue Dec 8, 2023
Updates the HtmlUnit Java dependency to the latest major release
according to the migration guide:
https://www.htmlunit.org/migration.html

Resolves: vulnerability CVE-2023-26119

Related #13171

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
@titusfortner
Copy link
Member

@diemol did that PR fix this issue?

@rbri
Copy link
Contributor Author

rbri commented Jan 2, 2024

@titusfortner sorry but the pr updates the htmlunit dependencies instead of removing it

And btw: Happy new year to you all

@joerg1985
Copy link
Member

@rbri i think these files are generated by bazel at build time and should be in place as soon as the tests are running:

copy_file(
name = "execute_script",
src = "//javascript/atoms/fragments:execute-script.js",
out = "execute_script.js",
)
copy_file(
name = "atoms_inputs",
src = "//javascript/webdriver/atoms:inputs_bin.js",
out = "atoms_inputs.js",
)

After running bazel test --cache_test_results=no --test_size_filters=small grid java/... they are generated:

image

@rbri
Copy link
Contributor Author

rbri commented Jan 13, 2024

ok, i see having this dependency to htmlunit-core-js still makes sense.
I think we can close this.

@joerg1985 / @diemol do you like to close or should i do?

@diemol diemol closed this as completed Jan 14, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues looking for contributions I-defect
Projects
None yet
Development

No branches or pull requests

5 participants