Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Deprecation warnings for Ruby 2.7.1 (webdriver chrome) #8315

Closed
navidemad opened this issue May 16, 2020 · 4 comments
Closed

[rb] Deprecation warnings for Ruby 2.7.1 (webdriver chrome) #8315

navidemad opened this issue May 16, 2020 · 4 comments
Labels

Comments

@navidemad
Copy link

navidemad commented May 16, 2020

🐛 Bug Report

There are deprecation warnings left for Selenium in Ruby 2.7.1 on OSX Mac OS.
They're all from this change to position arguments/kwargs.
Some has been fixed in the past in the following issue : Ruby 2.7 deprecations #7870

/lib/selenium/webdriver/chrome/options.rb:77: 
   warning: 
      Using the last argument as keyword parameters is deprecated;
      maybe ** should be added to the call
/lib/selenium/webdriver/common/options.rb:25:
   warning:
      The called method `initialize' is defined here

Expected behavior

I had expect no deprecation warnings.

Test script or set of commands reproducing this issue

Detailed steps to reproduce the behavior:

require 'bundler/inline'
gemfile(true) do
  source 'https://rubygems.org'
  ruby '2.7.1'
  gem 'selenium-webdriver', '4.0.0.alpha5' # Warnings present
  #gem 'selenium-webdriver', '3.142.7' # Warning free
end
Selenium::WebDriver::Chrome::Options.new
@ghost ghost added the needs-triaging label May 16, 2020
@p0deje
Copy link
Member

p0deje commented May 17, 2020

Thanks for the report! I will address it as soon as possible. Pull requests are also welcome!

@seanpoulter
Copy link
Contributor

seanpoulter commented Jun 7, 2020

Sorry to post on an old issue but is Ruby 2.7.x supported? The docs say otherwise. I've tried to summarize what versions I've found in #8395. It's a bit of a mess.

@navidemad
Copy link
Author

I am using 2.7.1, everything seems to be working for me at least @seanpoulter

@seanpoulter
Copy link
Contributor

Thanks Navid. I'll update the issue. 👍

titusfortner pushed a commit to titusfortner/selenium that referenced this issue Aug 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants