[rb] fix http proxy configuration for chrome #13093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an error that made selenium skip passing the http proxy params to chrome and chromium.
Motivation and Context
After investigating an error that started after bumping selenium, we realized the proxy configuration was being loaded incorrectly. After much research into it, we discovered the error was likely coming from how selenium passed the arguments. The error is the following:
Selenium::WebDriver::Error::NoSuchDriverError
Unable to obtain chromedriver using Selenium Manager; Unsuccessful command executed: ["/usr/local/bundle/gems/selenium-webdriver-4.14.0/bin/linux/selenium-manager", "--browser", "chrome", "--proxy", nil, "--output", "json"]; no implicit conversion of nil into String; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors/driver_location
Types of changes
Checklist