You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add version constraints to dependencies in the uses section
For better traceability and management of dependencies, consider adding explicit version constraints to the uses dependencies in the java_export target.
Why: Adding explicit version constraints to dependencies enhances traceability and management of dependencies, which is crucial for maintaining stable builds. This is a best practice that addresses a significant aspect of dependency management.
9
Specify the output directory for the bazel build command
Consider specifying the output directory for the bazel build command to ensure that the build artifacts are stored in a predictable and controlled location. This can help in managing the artifacts more effectively, especially in CI environments.
Why: Specifying the output directory for the bazel build command can help in managing build artifacts more effectively, especially in CI environments. This is a best practice that can improve the predictability and control of build outputs.
8
Maintainability
Add a description to the pkg_zip target
It's recommended to add a description for the pkg_zip target to clarify its purpose and usage within the project. This can improve maintainability and understanding of the build configuration.
pkg_zip(
name = "strongnamed",
srcs = [
"//dotnet/src/support:support-strongnamed-pack",
"//dotnet/src/webdriver:webdriver-strongnamed-pack",
],
tags = [
"release-artifact",
],
+ description = "Package for strongly named assemblies of the project."
)
Apply this suggestion
Suggestion importance[1-10]: 7
Why: Adding a description to the pkg_zip target can improve maintainability and understanding of the build configuration. This is a minor but useful improvement for documentation purposes.
7
Standardize the formatting of the tags list
Ensure consistent formatting of the tags list across all java_export targets to improve readability and maintainability of the build scripts.
Why: Standardizing the formatting of the tags list improves readability and maintainability of the build scripts. This is a minor improvement focused on code style.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
This means the
ci-build.sh
script can be shrunk by removing the hard-coded list of artifacts.PR Type
Enhancement, Configuration changes
Description
ci-build.sh
script.release-artifact
tag to various Bazel build targets across multiple languages (.NET, Java, JavaScript, Python, Ruby).release-artifact
tag.Changes walkthrough 📝
1 files
ci-build.sh
Dynamically select artifacts to build using tag filters
scripts/github-actions/ci-build.sh
--build_tag_filters=release-artifact
to dynamically selectartifacts.
24 files
BUILD.bazel
Add release-artifact tag to .NET build targets
dotnet/BUILD.bazel
release-artifact
tag tostrongnamed
andrelease
targets.BUILD.bazel
Add release-artifact tag to Selenium Java API targets
java/src/org/openqa/selenium/BUILD.bazel
release-artifact
tag toselenium-api
andclient-combined
targets.
BUILD.bazel
Add release-artifact tag to Selenium Chrome driver target
java/src/org/openqa/selenium/chrome/BUILD.bazel
release-artifact
tag tochrome
target.BUILD.bazel
Add release-artifact tag to Selenium Chromium driver target
java/src/org/openqa/selenium/chromium/BUILD.bazel
release-artifact
tag tochromium
target.BUILD.bazel
Add release-artifact tag to Selenium DevTools v125 target
java/src/org/openqa/selenium/devtools/v125/BUILD.bazel
release-artifact
tag toselenium-devtools-v125
target.BUILD.bazel
Add release-artifact tag to Selenium DevTools v126 target
java/src/org/openqa/selenium/devtools/v126/BUILD.bazel
release-artifact
tag toselenium-devtools-v126
target.BUILD.bazel
Add release-artifact tag to Selenium DevTools v127 target
java/src/org/openqa/selenium/devtools/v127/BUILD.bazel
release-artifact
tag toselenium-devtools-v127
target.BUILD.bazel
Add release-artifact tag to Selenium DevTools v85 target
java/src/org/openqa/selenium/devtools/v85/BUILD.bazel
release-artifact
tag toselenium-devtools-v85
target.BUILD.bazel
Add release-artifact tag to Selenium Edge driver target
java/src/org/openqa/selenium/edge/BUILD.bazel
release-artifact
tag toedge
target.BUILD.bazel
Add release-artifact tag to Selenium Firefox driver target
java/src/org/openqa/selenium/firefox/BUILD.bazel
release-artifact
tag tofirefox
target.BUILD.bazel
Add release-artifact tag to Selenium Grid and BOM targets
java/src/org/openqa/selenium/grid/BUILD.bazel
release-artifact
tag toselenium-bom
andgrid
targets.BUILD.bazel
Add release-artifact tag to Selenium JDBC session map target
java/src/org/openqa/selenium/grid/sessionmap/jdbc/BUILD.bazel
release-artifact
tag tojdbc
target.BUILD.bazel
Add release-artifact tag to Selenium Redis session map target
java/src/org/openqa/selenium/grid/sessionmap/redis/BUILD.bazel
release-artifact
tag toredis
target.BUILD.bazel
Add release-artifact tag to Selenium IE driver target
java/src/org/openqa/selenium/ie/BUILD.bazel
release-artifact
tag toie
target.BUILD.bazel
Add release-artifact tag to Selenium JSON target
java/src/org/openqa/selenium/json/BUILD.bazel
release-artifact
tag tojson
target.BUILD.bazel
Add release-artifact tag to Selenium Manager target
java/src/org/openqa/selenium/manager/BUILD.bazel
release-artifact
tag tomanager
target.BUILD.bazel
Add release-artifact tag to Selenium OS target
java/src/org/openqa/selenium/os/BUILD.bazel
release-artifact
tag toos
target.BUILD.bazel
Add release-artifact tag to Selenium Remote Driver target
java/src/org/openqa/selenium/remote/BUILD.bazel
release-artifact
tag toremote-driver
target.BUILD.bazel
Add release-artifact tag to Selenium HTTP target
java/src/org/openqa/selenium/remote/http/BUILD.bazel
release-artifact
tag tohttp
target.BUILD.bazel
Add release-artifact tag to Selenium Safari driver target
java/src/org/openqa/selenium/safari/BUILD.bazel
release-artifact
tag tosafari
target.BUILD.bazel
Add release-artifact tag to Selenium Support target
java/src/org/openqa/selenium/support/BUILD.bazel
release-artifact
tag tosupport
target.BUILD.bazel
Add release-artifact tag to Selenium WebDriver JavaScript target
javascript/node/selenium-webdriver/BUILD.bazel
release-artifact
tag toselenium-webdriver
target.BUILD.bazel
Add release-artifact tag to Selenium Python Wheel target
py/BUILD.bazel
release-artifact
tag toselenium-wheel
target.BUILD.bazel
Add release-artifact tag to Selenium Ruby targets
rb/BUILD.bazel
release-artifact
tag toselenium-webdriver
andselenium-devtools
targets.