-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix type errors for service.py
, cdp.py
, webelement.py
and remote_connection.py
#14448
Conversation
…te_connection.py`
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes the mypy type errors for multiple files.
Types of changes
Checklist
PR Type
Bug fix
Description
cast
for type hinting.None
values and appropriate error handling in service-related files.remote_connection.py
to usegetdefaulttimeout
.send_keys
method inwebelement.py
handles values as tuples.Changes walkthrough 📝
cdp.py
Add type annotations for event channels
py/selenium/webdriver/common/bidi/cdp.py
sender
andreceiver
variables.service.py
Fix type errors and add type casting
py/selenium/webdriver/common/service.py
cast
for type hinting onlog_output
.None
path instart
method.cast
forstdout
andstderr
in subprocess.remote_connection.py
Update timeout initialization for remote connection
py/selenium/webdriver/remote/remote_connection.py
getdefaulttimeout
.webelement.py
Fix type error in send_keys method
py/selenium/webdriver/remote/webelement.py
value
to a tuple forsend_keys
method.service.py
Add type annotations and remove type ignore
py/selenium/webdriver/webkitgtk/service.py
DEFAULT_EXECUTABLE_PATH
.service.py
Add executable check and remove type ignore
py/selenium/webdriver/wpewebkit/service.py