-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] add execute_cdp_cmd to Remote #14809
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Do you think we should add a test for it? |
I don't see any tests of |
@p0deje, do you think this is fine to merge? |
@VietND96 Doesn't this create a duplication as we already have the same method in ChromiumDriver? I am not sure how to re-use it, but maybe we can at least remove it from ChromiumDriver. |
Let's add a deprecation warning before removing it? |
@Delta456, I saw |
I will try |
Yes, we can use the same method from Remote. I think we can merge this for now. We can think of a deprecation warning afterwards. |
Thank you, @Delta456 ! |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Implements
execute_cdp_cmd
for Remote WebDriverMotivation and Context
Implements #14799 as it should be accessible via Remote driver as well since Grid provides the endpoints and the underlying command executor
Types of changes
Checklist
PR Type
Enhancement
Description
execute_cdp_cmd
method to the Remote WebDriver class, enabling the execution of Chrome DevTools Protocol commands.Changes walkthrough 📝
webdriver.py
Add `execute_cdp_cmd` method to Remote WebDriver
py/selenium/webdriver/remote/webdriver.py
execute_cdp_cmd
method to the Remote WebDriver class.