-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] moved all getters in fedcm/account.py
into descriptor object.
#14858
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the refactoring
Thank you, @sandeepsuryaprasad ! |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Moved all getters in fedcm/account.py to
descriptor
objectMotivation and Context
getters
doing similar job.Types of changes
Checklist
PR Type
enhancement
Description
_AccountDescriptor
class to implement the descriptor pattern for theAccount
class attributes.Account
class with instances of_AccountDescriptor
, simplifying the class structure._AccountDescriptor
class.Changes walkthrough 📝
account.py
Refactor Account class to use descriptor pattern
py/selenium/webdriver/common/fedcm/account.py
_AccountDescriptor
class for descriptor pattern._AccountDescriptor
instances.Account
class by using descriptors for attributes.