Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'isInvisible()' now returns true on 'NoSuchElementException' instead of causing 'TimeoutException' #8063

Merged
merged 2 commits into from
Mar 27, 2020
Merged

'isInvisible()' now returns true on 'NoSuchElementException' instead of causing 'TimeoutException' #8063

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4153c43
'isInvisible()' returns true on 'NoSuchElementException'
Feb 27, 2020
88e8830
Merge branch 'master' into master
AutomatedTester Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/client/src/org/openqa/selenium/support/ui/ExpectedConditions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,7 +1346,7 @@ public String toString() {
private static boolean isInvisible(final WebElement element) {
try {
return !element.isDisplayed();
} catch (StaleElementReferenceException ignored) {
} catch (StaleElementReferenceException | NoSuchElementException ignored) {
// We can assume a stale element isn't displayed.
return true;
}
Expand Down