Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL to URI #8448

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Fix URL to URI #8448

merged 2 commits into from
Jun 22, 2020

Conversation

shucon
Copy link
Contributor

@shucon shucon commented Jun 22, 2020 •
edited
Loading

Partial-PR: #8020

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shucon
Copy link
Contributor Author

shucon commented Jun 22, 2020

@shs96c @AutomatedTester

@shucon shucon changed the title Fix URL to URI and add host annd port support Fix URL to URI and add host and port support Jun 22, 2020
shs96c
shs96c requested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. I'm not keen on the duplicated data.

java/server/src/org/openqa/selenium/grid/graphql/selenium-grid-schema.graphqls Outdated Show resolved Hide resolved
java/server/src/org/openqa/selenium/grid/graphql/Grid.java Outdated Show resolved Hide resolved
java/server/src/org/openqa/selenium/grid/graphql/Grid.java Outdated Show resolved Hide resolved
java/server/src/org/openqa/selenium/grid/graphql/Node.java Outdated Show resolved Hide resolved
java/server/src/org/openqa/selenium/grid/graphql/Node.java Outdated Show resolved Hide resolved
java/server/src/org/openqa/selenium/grid/graphql/Node.java Outdated Show resolved Hide resolved
java/server/src/org/openqa/selenium/grid/graphql/selenium-grid-schema.graphqls Show resolved Hide resolved
java/server/src/org/openqa/selenium/grid/graphql/selenium-grid-schema.graphqls Outdated Show resolved Hide resolved
@shucon shucon changed the title Fix URL to URI and add host and port support Fix URL to URI Jun 22, 2020
@shucon shucon requested a review from shs96c June 22, 2020 16:28
@shs96c
Copy link
Member

shs96c commented Jun 22, 2020

This looks great now. Thank you for the changes, and thank you for pushing this forwards :)

@shs96c shs96c merged commit 4432967 into SeleniumHQ:master Jun 22, 2020
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
@shucon @titusfortner
Fix URL to URI (SeleniumHQ#8448)
961b88a 
Fix URL to URI and add host annd port support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shucon @shs96c