Add a(n E2E) test for basic (left) arrow key usage #8492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomatedTester
requested changes
Jul 9, 2020
java/client/test/org/openqa/selenium/interactions/BasicKeyboardInterfaceTest.java
Outdated
Show resolved
Hide resolved
java/client/test/org/openqa/selenium/interactions/BasicKeyboardInterfaceTest.java
Outdated
Show resolved
Hide resolved
Fixes: SeleniumHQ#8483 Reviewed-By: David Burns <david.burns@theautomatedtester.co.uk>
|
just going to wait for travis before merging |
Cool. P.S. FYI, i re-used single_text_input.html (re-use of code that already exists is frequently the best thing to do, & seems to be the case for the page aspect here). |
…in this class) Fixes: SeleniumHQ#8483 Reviewed-By: David Burns <david.burns@theautomatedtester.co.uk>
AutomatedTester
approved these changes
Jul 10, 2020
titusfortner
pushed a commit
to titusfortner/selenium
that referenced
this pull request
Aug 13, 2020
* Add a(n E2E) test for (left) arrow key usage Fixes: SeleniumHQ#8483 * Updates based on code review: local constants, & usage of local page Fixes: SeleniumHQ#8483 Reviewed-By: David Burns <david.burns@theautomatedtester.co.uk> * Use assertThat(actual).isEqualTo(expected) (based on prevalent usage in this class) Fixes: SeleniumHQ#8483 Reviewed-By: David Burns <david.burns@theautomatedtester.co.uk> Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk> Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8483
Description
Helps ensure that Selenium supports basic (left) arrow key usage
Motivation and Context
I used this to determine that the issue i've worked around stems from Quill(JS.com), rather than Selenium
Types of changes
Checklist