Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracing] Add missing spans to Grid #8529

Merged

Conversation

pujagani
Copy link
Contributor

Description

The changes are related to issue #6703.

Motivation and Context

This helps ensure the existing trace is complete for a request flow.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani changed the title [tracing] Add span in DockerSessionFactory [tracing] Add missing spans to Grid Jul 15, 2020
@AutomatedTester AutomatedTester merged commit 4e2e26f into SeleniumHQ:trunk Jul 15, 2020
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
* [tracing] Add span in DockerSessionFactory

* [tracing] Add spans to LocalSessionMap

Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants