Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS]Cleaning up chrome.js file #8811

Merged
merged 5 commits into from
Oct 23, 2020
Merged

[JS]Cleaning up chrome.js file #8811

merged 5 commits into from
Oct 23, 2020

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Oct 21, 2020 •
edited
Loading

Description

Removing duplicate declarations from chrome as chrome extends chromium.js

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@harsha509 harsha509 requested a review from corevo October 21, 2020 07:35
AutomatedTester
AutomatedTester approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@AutomatedTester AutomatedTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have something like the description as the commit message so that we can see what the changes are when we look at the git log.

javascript/node/selenium-webdriver/chrome.js Outdated Show resolved Hide resolved
@harsha509
Copy link
Member Author

Could we have something like the description as the commit message so that we can see what the changes are when we look at the git log.

Thank you for the review @AutomatedTester. I have updated the git commit message.

@diemol diemol merged commit 7f376a6 into SeleniumHQ:trunk Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

@AutomatedTester AutomatedTester AutomatedTester approved these changes

@corevo corevo Awaiting requested review from corevo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harsha509 @AutomatedTester @diemol