Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Remove GridShutdown test since Grid 4 has the functionality
Motivation and Context
Grid 3 :
GridRegistry is the central place of the Grid where each Node registers itself to the Hub. It assigns any new incoming request to the queue and maintains HTTP connections to the Node.
Hence, to control its lifecycle, correctly clean up the resources and stop threads, shutdown() method is used. It stops the queue, stops the request matching thread, stops all registered nodes and closes the HTTP client connections.
Grid 4 :
The current implementation for Grid 4 is very different. The fully distributed mode has 5 components. Each component runs as a netty server. The netty server implements a stop() method, that stops all its thread groups gracefully. Additionally, there are JVM hooks to shutdown any ongoing threads like the new session distributor thread, retry request session queue thread. The JVM hook also shuts down the async HTTP client to free up the resources. There are separate endpoints to drain a node which in turns frees up the resources. However, there is no single endpoint/method to be called that can explicitly shut down the entire grid since this is a security risk.
Types of changes
Checklist