Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid] Remove GridShutdown test #9410

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Remove GridShutdown test since Grid 4 has the functionality

Motivation and Context

Grid 3 :
GridRegistry is the central place of the Grid where each Node registers itself to the Hub. It assigns any new incoming request to the queue and maintains HTTP connections to the Node.
Hence, to control its lifecycle, correctly clean up the resources and stop threads, shutdown() method is used. It stops the queue, stops the request matching thread, stops all registered nodes and closes the HTTP client connections.

Grid 4 :
The current implementation for Grid 4 is very different. The fully distributed mode has 5 components. Each component runs as a netty server. The netty server implements a stop() method, that stops all its thread groups gracefully. Additionally, there are JVM hooks to shutdown any ongoing threads like the new session distributor thread, retry request session queue thread. The JVM hook also shuts down the async HTTP client to free up the resources. There are separate endpoints to drain a node which in turns frees up the resources. However, there is no single endpoint/method to be called that can explicitly shut down the entire grid since this is a security risk.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pujagani!

@diemol diemol merged commit 192e347 into SeleniumHQ:trunk Apr 22, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants