-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Python Examples for Options #2010
Updated Python Examples for Options #2010
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @shbenzer !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Failure has nothing to do with submitted code - though I do see it occasionally on other PRs. Do we know why this test fails on Ubuntu? |
Looks like a flaky one..! Looking into it! |
* Updated Python Examples for Options * think set_window_rect() is just supported for firefox --------- Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> 8deef6c
User description
Updated Python examples in Browser Options
Description
added examples to test_options.py
made examples more consistent with other language examples
updated all translations of index.mds
Motivation and Context
Issue #1983
Types of changes
Checklist
PR Type
Tests, Documentation
Description
Changes walkthrough 📝
test_options.py
Enhance and unify Python test examples for browser options
examples/python/tests/drivers/test_options.py
FirefoxOptions
toChromeOptions
intest_set_window_rect
.options.en.md
Update English documentation with new Python example references
website_and_docs/content/documentation/webdriver/drivers/options.en.md
options.ja.md
Update Japanese documentation with new Python example references
website_and_docs/content/documentation/webdriver/drivers/options.ja.md
options.pt-br.md
Update Portuguese documentation with new Python example references
website_and_docs/content/documentation/webdriver/drivers/options.pt-br.md
options.zh-cn.md
Update Chinese documentation with new Python example references
website_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md