Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] fix java code lines for edge #2103

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

Delta456
Copy link
Contributor

@Delta456 Delta456 commented Dec 16, 2024

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Fix line number for Java Edge code

Motivation and Context

They were missing and empty

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Updated Java code line references in Edge browser documentation to match the correct line numbers in EdgeTest.java file
  • Changes applied across multiple language versions:
    • English (en)
    • Japanese (ja)
    • Portuguese (pt-br)
    • Chinese (zh-cn)

Changes walkthrough 📝

Relevant files
Documentation
edge.en.md
Update Java code line references for Edge documentation   

website_and_docs/content/documentation/webdriver/browsers/edge.en.md

  • Updated Java code line references to match the correct line numbers in
    EdgeTest.java
  • +11/-11 
    edge.ja.md
    Update Java code line references in Japanese Edge documentation

    website_and_docs/content/documentation/webdriver/browsers/edge.ja.md

  • Updated Java code line references to match the correct line numbers in
    EdgeTest.java
  • +11/-11 
    edge.pt-br.md
    Update Java code line references in Portuguese Edge documentation

    website_and_docs/content/documentation/webdriver/browsers/edge.pt-br.md

  • Updated Java code line references to match the correct line numbers in
    EdgeTest.java
  • +10/-10 
    edge.zh-cn.md
    Update Java code line references in Chinese Edge documentation

    website_and_docs/content/documentation/webdriver/browsers/edge.zh-cn.md

  • Updated Java code line references to match the correct line numbers in
    EdgeTest.java
  • +11/-11 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    netlify bot commented Dec 16, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit e786855

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Documentation Update
    Verify that the new line numbers correctly match the actual code in EdgeTest.java file

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @Delta456 !

    @harsha509 harsha509 merged commit 66bd786 into SeleniumHQ:trunk Dec 16, 2024
    3 checks passed
    selenium-ci added a commit that referenced this pull request Dec 16, 2024
    Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> 66bd786
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants