feat(Menu): add left value to the position prop (#1852)

Semantic-Org · Jul 16, 2017 · 929305e · 929305e
1 parent 5a48d58
commit 929305e
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/src/collections/Menu/MenuItem.d.ts b/src/collections/Menu/MenuItem.d.ts
@@ -58,8 +58,8 @@ export interface MenuItemProps {
    */
   onClick?: (event: React.MouseEvent<HTMLAnchorElement>, data: MenuItemProps) => void;
 
-  /** A menu item can take right position. */
-  position?: 'right';
+  /** A menu item can take left or right position. */
+  position?: 'left' | 'right';
 }
 
 declare const MenuItem: React.ComponentClass<MenuItemProps>;

diff --git a/src/collections/Menu/MenuItem.js b/src/collections/Menu/MenuItem.js
@@ -75,8 +75,8 @@ export default class MenuItem extends Component {
      */
     onClick: PropTypes.func,
 
-    /** A menu item can take right position. */
-    position: PropTypes.oneOf(['right']),
+    /** A menu item can take left or right position. */
+    position: PropTypes.oneOf(['left', 'right']),
   }
 
   static _meta = {

diff --git a/src/collections/Menu/MenuMenu.d.ts b/src/collections/Menu/MenuMenu.d.ts
@@ -12,8 +12,8 @@ export interface MenuMenuProps {
   /** Additional classes. */
   className?: string;
 
-  /** A sub menu can take right position. */
-  position?: 'right';
+  /** A sub menu can take left or right position. */
+  position?: 'left' | 'right';
 }
 
 declare const MenuMenu: React.StatelessComponent<MenuMenuProps>;

diff --git a/src/collections/Menu/MenuMenu.js b/src/collections/Menu/MenuMenu.js
@@ -42,8 +42,8 @@ MenuMenu.propTypes = {
   /** Additional classes. */
   className: PropTypes.string,
 
-  /** A sub menu can take right position. */
-  position: PropTypes.oneOf(['right']),
+  /** A sub menu can take left or right position. */
+  position: PropTypes.oneOf(['left', 'right']),
 }
 
 export default MenuMenu
diff --git a/test/specs/collections/Menu/MenuItem-test.js b/test/specs/collections/Menu/MenuItem-test.js
@@ -22,7 +22,7 @@ describe('MenuItem', () => {
   common.propKeyOrValueAndKeyToClassName(MenuItem, 'fitted', ['horizontally', 'vertically'])
 
   common.propValueOnlyToClassName(MenuItem, 'color', SUI.COLORS)
-  common.propValueOnlyToClassName(MenuItem, 'position', ['right'])
+  common.propValueOnlyToClassName(MenuItem, 'position', ['left', 'right'])
 
   it('renders a `div` by default', () => {
     shallow(<MenuItem />)

diff --git a/test/specs/collections/Menu/MenuMenu-test.js b/test/specs/collections/Menu/MenuMenu-test.js
@@ -5,5 +5,5 @@ describe('MenuMenu', () => {
   common.isConformant(MenuMenu)
   common.rendersChildren(MenuMenu)
 
-  common.propValueOnlyToClassName(MenuMenu, 'position', ['right'])
+  common.propValueOnlyToClassName(MenuMenu, 'position', ['left', 'right'])
 })