Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup: Floating elements not positioned properly #4092

Closed
qooban opened this issue Oct 22, 2020 · 3 comments · Fixed by #4094
Closed

Popup: Floating elements not positioned properly #4092

qooban opened this issue Oct 22, 2020 · 3 comments · Fixed by #4094
Assignees
Labels

Comments

@qooban
Copy link

qooban commented Oct 22, 2020

Bug Report

In new Popup component floated elements are not positioned properly. That is probably because of two div blocks instead of one div block (in v1.x) rendered as part of Popup component.

Steps

Just try:

<Popup trigger={<Button>Hover me</Button>}>
    <Button floated="right">Test</Button>
</Popup>

Codesanbox with the same example available below.

Expected Result

Button "Test" is inside the popup.

Actual Result

Button "Test" is partially outside of the popup.

Version

2.0.0

Testcase

https://codesandbox.io/s/semantic-ui-react-forked-he9zh

@welcome
Copy link

welcome bot commented Oct 22, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter
Copy link
Member

@qooban Thanks for reporting, I fixed the issue in #4094 (visual tests were also added). I expect that we will release it in 2.0.1 on Monday.

@layershifter
Copy link
Member

Released in semantic-ui-react@2.0.1 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants