fix(Popup): transfer zIndex & fix floated elements #4094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zIndex
transferingFixes #4083.
In #3947 a wrapping element was added around
.popup
to avoid Popper.js warnings and position arrows properly. However, that created an issue withzIndex
as it was defined inside a nested element:There were multiple proposals in #4083, however I decided to go with syncing
zIndex
and avoid hardcoded values in JS code:floated elements
Fixes #4092. As was reported in that issue elements that have
float
CSS properly were breaking layout, this was fixed by addingdisplay: flex
to a wrapping element.popper
shorthandA wrapping element is accessible as a shorthand now, this allows to apply custom props and styling:
✅ An example to docs was also added.