Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(LabelExamplePointingColored): Remove basic property from labels #3209

Closed
wants to merge 1 commit into from
Closed

Conversation

ahacop
Copy link

@ahacop ahacop commented Oct 11, 2018

Prior to this commit, label text was illegible as both the text and label background color were red.

Before:
screen shot 2018-10-11 at 15 17 29
After:
screen shot 2018-10-11 at 15 17 55

…omponents

Prior to this commit, label text was illegible as both the text and label background color were red.
@welcome
Copy link

welcome bot commented Oct 11, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3209   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         169      169           
  Lines        2790     2790           
=======================================
  Hits         2788     2788           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201ff7a...3ffb556. Read the comment docs.

@layershifter
Copy link
Member

layershifter commented Oct 11, 2018

https://semantic-ui.com/elements/label.html#pointing

https://github.com/Semantic-Org/Semantic-UI/blob/master/RELEASE-NOTES.md
Semantic-Org/Semantic-UI#6440

This was fixed in SUI 2.4 and already fixed in master branch. The next release of SUIR will also add new features from SUI 2.4, however feel free to use the latest version of SUI, it's fully compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants