Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sidebar): fix issue with Portals in React 17 #4144

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jan 18, 2021

Fixes #4110.

A fix was done in microsoft/fluentui#16514, the issue is related to a bug in React (facebook/react#20074). An integration test was added to ensure that the issue was actually fixed.

@github-actions
Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 58.58 KB (0%)
bundle-size/dist/Icon.size.js 25.06 KB (0%)
bundle-size/dist/Image.size.js 53.76 KB (0%)
bundle-size/dist/Modal.size.js 68.66 KB (0%)
bundle-size/dist/Portal.size.js 40.46 KB (0%)

@codecov-io
Copy link

codecov-io commented Jan 19, 2021

Codecov Report

Merging #4144 (33d95c7) into master (d2be2e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4144   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3241     3241           
=======================================
  Hits         3233     3233           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fadae0...33d95c7. Read the comment docs.

@layershifter layershifter merged commit ad261dd into master Jan 19, 2021
@layershifter layershifter deleted the fix/sidebar-click branch January 19, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal kills the Pushable Sidebar
2 participants