Skip to content

Commit

Permalink
#3432 Simplifies setting name (derp), adds default to false
Browse files Browse the repository at this point in the history
  • Loading branch information
jlukic committed Jan 29, 2018
1 parent 0fa5821 commit 32d47d6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- **Button** - Youtube's red color now matches their current brand guidelines **Thanks @hammy2899** #6110
- **Flag** - Adds missing flag for England **Thanks @zyzniewski** #5944
- **Reveal** - `ribbon label` can now work with `reveal` #5681
- **Dropdown** - Added new setting `ignoreCase` (defaults to false) that will prevent values from being added that match existing values (case insensitive). This is particularly useful when using allowAdditions for tagging to not allow case insensitive matches.

**Bugs**
- **Dropdown** - Fixed issue where dropdownsdown could incorrectly open upward and leftward opening when using `context` setting due to an incorrect offset calculation. **Thanks @dannyBies** #5974 #5366
Expand Down
4 changes: 2 additions & 2 deletions src/definitions/modules/dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -3061,7 +3061,7 @@ $.fn.dropdown = function(parameters) {
return (module.get.query() !== '');
},
value: function(value) {
return (settings.ignoreAdditionCase)
return (settings.ignoreCase)
? module.has.valueIgnoringCase(value)
: module.has.valueMatchingCase(value)
;
Expand Down Expand Up @@ -3694,7 +3694,7 @@ $.fn.dropdown.settings = {
forceSelection : true, // force a choice on blur with search selection

allowAdditions : false, // whether multiple select should allow user added values
ignoreAdditionCase : true, // whether to ignore case when adding a user selection
ignoreCase : false, // whether to consider values not matching in case to be the same
hideAdditions : true, // whether or not to hide special message prompting a user they can enter a value

maxSelections : false, // When set to a number limits the number of selections to this count
Expand Down

0 comments on commit 32d47d6

Please sign in to comment.