Skip to content

Commit

Permalink
Fixes #2806 issue with trim in dropdown
Browse files Browse the repository at this point in the history
  • Loading branch information
jlukic committed Aug 11, 2015
1 parent 938a32e commit b615696
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
- **Transition** - Transition callbacks now all have the correct `this` set. #2758
- **Form / Input** - Fixes `::placeholder` text color for `ui error input`, modifies form error placeholder color to distinguish from form value error color #2786
- **Form** - Date input and other special input in chrome now are the same height as normal input (adds custom vendor shadow dom styling) #2704
- **Dropdown** - Remove use of `trim` which causes issues IE 11 and below #2806

**Additional Bugs**
- **Build Tools** - Fixes issue on `win` platform where packaged theme would not correctly update when using watch due to regExp not matching windows path separators.
Expand Down
6 changes: 3 additions & 3 deletions src/definitions/modules/dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -1509,8 +1509,8 @@ $.fn.dropdown = function(parameters) {
return ($choice.data(metadata.text) !== undefined)
? $choice.data(metadata.text)
: (preserveHTML)
? $choice.html().trim()
: $choice.text().trim()
? $.trim($choice.html())
: $.trim($choice.text())
;
}
},
Expand All @@ -1522,7 +1522,7 @@ $.fn.dropdown = function(parameters) {
return ($choice.data(metadata.value) !== undefined)
? $choice.data(metadata.value)
: (typeof choiceText === 'string')
? choiceText.toLowerCase().trim()
? $.trim(choiceText.toLowerCase())
: choiceText
;
},
Expand Down

0 comments on commit b615696

Please sign in to comment.