Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Divider] Remove Left Property When Positioned Between Columns #2808

Closed
fstanis opened this issue Aug 7, 2015 · 1 comment
Closed

[Divider] Remove Left Property When Positioned Between Columns #2808

fstanis opened this issue Aug 7, 2015 · 1 comment
Milestone

Comments

@fstanis
Copy link

fstanis commented Aug 7, 2015

I tried to create a two column grid divided by an OR divider, exactly like the vertical divider example. However, when I decided to make the left column narrower than the right, a problem arose - the divider is always exactly on the middle instead of being between the two columns (fiddle here - it's a good idea to increase the width of the Result area).

This turns out to be caused by CSS rule for .ui.vertical.divider that states left: 50%. After removing this rule, the divider positions itself perfectly. Here's a second fiddle which demonstrates this. Is there any reason to keep this left: 50% property?

@jlukic
Copy link
Member

jlukic commented Aug 8, 2015

I think this makes sense to add for ui.grid > .column + .divider. I'm sure you're also familiar with ui vertically divided grid which does this without labels.

In cases outside a grid hwoever, a divider has to assume it needs to position itself.

@jlukic jlukic changed the title Vertical divider only works for dividing two equal-width columns [Divider] Remove Left Property When Positioned Between Columns Aug 8, 2015
@jlukic jlukic added this to the 2.1 milestone Aug 8, 2015
@jlukic jlukic closed this as completed Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants