Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong calculation of "rail" element variables #3835

Closed
ikhilko opened this issue Mar 15, 2016 · 2 comments
Closed

Wrong calculation of "rail" element variables #3835

ikhilko opened this issue Mar 15, 2016 · 2 comments

Comments

@ikhilko
Copy link

ikhilko commented Mar 15, 2016

Looks like variables @closeWidth, @veryCloseWidth, @dividingWidth has bad unit calculations here:
https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/rail.variables#L26

As you can see
@closeWidth: @width(300px) + @splitCloseDistance(1em); will be calculated as 301px;
@veryCloseWidth: @width(300px) + @splitVeryCloseDistance(0.5em); will be calculated as 300.5px;
@dividingWidth: @width(300px) + @splitDividingDistance(2.5rem); will be calculated as 302.5px;

@jlukic
Copy link
Member

jlukic commented Mar 18, 2016

Yes, this is very clearly, entirely incorrect. Not sure how this was introduced.

The less rule should ether be in a calc statement and use border-box or the width should remain 300px and use content-box.

@jlukic jlukic added this to the 2.1.9 milestone Mar 18, 2016
@jlukic
Copy link
Member

jlukic commented Mar 29, 2016

Thanks for your patience

@jlukic jlukic closed this as completed Mar 29, 2016
@jlukic jlukic modified the milestones: 2.1.9, 2.2 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants